| Violation | Line |
|---|---|
| OS: org.apache.torque.task.TorqueSQLExec$Transaction.runTransaction(java.io.PrintStream) may fail to close stream on exception | 919 |
| Violation | Line |
|---|---|
| OS: org.apache.torque.task.TorqueDataSQLTask.initControlContext() may fail to close stream on exception | 186 |
| Violation | Line |
|---|---|
| DLS: Dead store to local variable in method org.apache.torque.task.TorqueJDBCTransformTask.getTableNames(java.sql.DatabaseMetaData) | 375 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.task.TorqueSQLExec.setRdbms(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 360 |
| Dm: Method org.apache.torque.task.TorqueSQLExec.setVersion(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 370 |
| Dm: Method org.apache.torque.task.TorqueSQLExec.isValidRdbms(java.sql.Connection) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 727 |
| RCN: Redundant nullcheck of value known to be non-null org.apache.torque.task.TorqueSQLExec.isValidRdbms(java.sql.Connection) | 730 |
| RCN: Redundant nullcheck of value known to be non-null org.apache.torque.task.TorqueSQLExec.isValidRdbms(java.sql.Connection) | 744 |
| OS: org.apache.torque.task.TorqueSQLExec.execute() may fail to close stream on exception | 421 |
| WMI: Method org.apache.torque.task.TorqueSQLExec.execute() makes inefficient use of keySet iterator instead of entrySet iterator | 438 |
| WMI: Method org.apache.torque.task.TorqueSQLExec.execute() makes inefficient use of keySet iterator instead of entrySet iterator | 463 |
| Violation | Line |
|---|---|
| EI: org.apache.torque.task.TorqueDataModelTask.getDataModelDbMap() may expose internal representation by returning org.apache.torque.task.TorqueDataModelTask.dataModelDbMap | 136 |
| WMI: Method org.apache.torque.task.TorqueDataModelTask.setContextProperties(String) makes inefficient use of keySet iterator instead of entrySet iterator | 358 |
| Violation | Line |
|---|---|
| OS: org.apache.torque.task.TorqueSQLTask.createSqlDbMap() may fail to close stream on exception | 131 |
| Violation | Line |
|---|---|
| ISC: Method org.apache.torque.task.TorqueDocumentationTask.initControlContext() needlessly instantiates a class that only supplies static methods | 62 |
| Violation | Line |
|---|---|
| ISC: Method org.apache.torque.task.TorqueDataDumpTask.initControlContext() needlessly instantiates a class that only supplies static methods | 206 |
| Violation | Line |
|---|---|
| OS: org.apache.torque.task.TorqueSQLTransformTask.execute() may fail to close stream on exception | 103 |
| REC: Method org.apache.torque.task.TorqueSQLTransformTask.execute() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 112 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.engine.platform.PlatformFactory.getClassnameFor(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 83 |
| Violation | Line |
|---|---|
| RI: Class org.apache.torque.engine.database.transform.XmlToData implements same interface as superclass. | 0 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.XmlToData.data | 0 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 145 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 201 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Primary(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 227 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Unique(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 274 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Foreign(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 309 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Data(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 397 |
| Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.execute() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 547 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.SQLToAppData.appDataDB | 0 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.SQLToAppData.tokens | 0 |
| Violation | Line |
|---|---|
| UI: Usage of GetResource in org.apache.torque.engine.database.transform.DTDResolver.<init>() may be unsafe if class is extended | 57 |
| Violation | Line |
|---|---|
| REC: Method org.apache.torque.engine.database.transform.XmlToAppData.parseFile(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 170 |
| REC: Method org.apache.torque.engine.database.transform.XmlToAppData.startElement(String,String,String,org.xml.sax.Attributes) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | 308 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.engine.database.model.ForeignKey.normalizeFKey(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 73 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.onDelete | 0 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.onUpdate | 0 |
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.parentTable | 0 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.engine.database.model.JavaNameGenerator.underscoreMethod(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 104 |
| Dm: Method org.apache.torque.engine.database.model.JavaNameGenerator.underscoreOmitSchemaMethod(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 147 |
| Violation | Line |
|---|---|
| Dm: Method org.apache.torque.engine.database.model.Column.setTypeFromString(String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | 912 |
| CD: Class org.apache.torque.engine.database.model.Column has a circular dependency with other classes. | 0 |
| CD: Class org.apache.torque.engine.database.model.Column has a circular dependency with other classes. | 0 |
| CD: Class org.apache.torque.engine.database.model.Column has a circular dependency with other classes. | 0 |
| Violation | Line |
|---|---|
| Dm: org.apache.torque.engine.database.model.Table.toString() invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | 1010 |
| Violation | Line |
|---|---|
| SnVI: org.apache.torque.engine.database.model.SchemaType is Serializable; consider declaring a serialVersionUID | 0 |
| Violation | Line |
|---|---|
| UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.IdMethodParameter.parentTable | 0 |
| CD: Class org.apache.torque.engine.database.model.IdMethodParameter has a circular dependency with other classes. | 0 |
| Violation | Line |
|---|---|
| SIC: Should org.apache.torque.engine.database.transform.XmlToData$ColumnValue be a _static_ inner class? | 0 |
| Violation | Line |
|---|---|
| SIC: Should org.apache.torque.engine.database.transform.XmlToData$DataRow be a _static_ inner class? | 0 |
| Violation | Line |
|---|---|
| CD: Class org.apache.torque.engine.database.model.Unique has a circular dependency with other classes. | 0 |